Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how JSONL datasets are loaded when
EP_JSONL_PATHis set by optionally routing rows throughdataset_adapter, which could alter row construction and labeling for existing env-driven workflows.Overview
When
EP_JSONL_PATHis used to auto-create aDynamicDataLoader, JSONL lines are now loaded as raw dicts and passed through the configureddataset_adapter(instead of always constructingEvaluationRow(**dict)).evaluation_testnow forwards itsdataset_adapterintoparse_ep_dataloaders, preserving adapter-specific fields (e.g., custom labels) for env-driven JSONL runs while keeping legacy behavior when no adapter is provided.Written by Cursor Bugbot for commit b42717b. This will update automatically on new commits. Configure here.